Skip to content

feat: Add openSUSE Leap vars#317

Merged
richm merged 5 commits intolinux-system-roles:mainfrom
HVSharma12:fix/add-leap-vars
Mar 16, 2026
Merged

feat: Add openSUSE Leap vars#317
richm merged 5 commits intolinux-system-roles:mainfrom
HVSharma12:fix/add-leap-vars

Conversation

@HVSharma12
Copy link
Copy Markdown
Contributor

@HVSharma12 HVSharma12 commented Mar 11, 2026

Enhancement: Add openSUSE Leap vars

Reason: Role fails on Leap due to missing vars

Result: Certificate role now works on leap 15

Issue Tracker Tickets (Jira or BZ if any): na

Summary by Sourcery

New Features:

  • Introduce distribution-specific vars file for openSUSE Leap 15.x, including default certificate directory and required Python cryptography-related packages.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds openSUSE Leap 15-specific Ansible variables so the certificate role works on that distribution by defining the default certificate directory and required Python package dependencies.

Sequence diagram for certificate role loading openSUSE Leap 15 vars

sequenceDiagram
  participant Ansible
  participant Certificate_role
  participant OS_facts
  participant Vars_openSUSE_Leap_15

  Ansible->>Certificate_role: include_role certificate
  Certificate_role->>OS_facts: gather_facts
  OS_facts-->>Certificate_role: ansible_distribution=openSUSE, ansible_distribution_major_version=15
  Certificate_role->>Certificate_role: select vars file for openSUSE Leap 15
  Certificate_role->>Vars_openSUSE_Leap_15: load vars/openSUSE_Leap_15.yml
  Vars_openSUSE_Leap_15-->>Certificate_role: __certificate_default_directory, __certificate_packages
  Certificate_role-->>Ansible: tasks run with correct directory and Python packages on Leap 15
Loading

File-Level Changes

Change Details Files
Introduce openSUSE Leap 15-specific Ansible vars to support the certificate role on that platform.
  • Create a new vars file for openSUSE Leap 15.x with SPDX license header and comments documenting Python interpreter rationale.
  • Define the default certificate directory path used by the certificate role for Leap 15.x.
  • Specify the Leap 15.x-specific Python package dependencies required for cryptography, D-Bus integration, and ASN.1 handling.
vars/openSUSE Leap_15.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The mix of python311-* and python3-pyasn1 package names is a bit inconsistent; if a python311-specific pyasn1 package exists on Leap 15, it would be clearer to use that for consistency with the chosen interpreter, or add a brief comment explaining why the generic python3 package is required here.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The mix of `python311-*` and `python3-pyasn1` package names is a bit inconsistent; if a `python311`-specific `pyasn1` package exists on Leap 15, it would be clearer to use that for consistency with the chosen interpreter, or add a brief comment explaining why the generic `python3` package is required here.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Copy Markdown
Collaborator

richm commented Mar 12, 2026

[citest]

@richm
Copy link
Copy Markdown
Collaborator

richm commented Mar 13, 2026

[citest]

1 similar comment
@richm
Copy link
Copy Markdown
Collaborator

richm commented Mar 13, 2026

[citest]

@richm
Copy link
Copy Markdown
Collaborator

richm commented Mar 13, 2026

@HVSharma12 please rebase on top of the latest main branch - this will pick up the addition of community.general and fix the container test failures

@richm
Copy link
Copy Markdown
Collaborator

richm commented Mar 14, 2026

[citest]

@richm richm merged commit 4479619 into linux-system-roles:main Mar 16, 2026
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants