feat: Add openSUSE Leap vars#317
Merged
richm merged 5 commits intolinux-system-roles:mainfrom Mar 16, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds openSUSE Leap 15-specific Ansible variables so the certificate role works on that distribution by defining the default certificate directory and required Python package dependencies. Sequence diagram for certificate role loading openSUSE Leap 15 varssequenceDiagram
participant Ansible
participant Certificate_role
participant OS_facts
participant Vars_openSUSE_Leap_15
Ansible->>Certificate_role: include_role certificate
Certificate_role->>OS_facts: gather_facts
OS_facts-->>Certificate_role: ansible_distribution=openSUSE, ansible_distribution_major_version=15
Certificate_role->>Certificate_role: select vars file for openSUSE Leap 15
Certificate_role->>Vars_openSUSE_Leap_15: load vars/openSUSE_Leap_15.yml
Vars_openSUSE_Leap_15-->>Certificate_role: __certificate_default_directory, __certificate_packages
Certificate_role-->>Ansible: tasks run with correct directory and Python packages on Leap 15
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The mix of
python311-*andpython3-pyasn1package names is a bit inconsistent; if apython311-specificpyasn1package exists on Leap 15, it would be clearer to use that for consistency with the chosen interpreter, or add a brief comment explaining why the genericpython3package is required here.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The mix of `python311-*` and `python3-pyasn1` package names is a bit inconsistent; if a `python311`-specific `pyasn1` package exists on Leap 15, it would be clearer to use that for consistency with the chosen interpreter, or add a brief comment explaining why the generic `python3` package is required here.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
richm
reviewed
Mar 11, 2026
richm
reviewed
Mar 12, 2026
Collaborator
|
[citest] |
richm
reviewed
Mar 13, 2026
Collaborator
|
[citest] |
1 similar comment
Collaborator
|
[citest] |
richm
approved these changes
Mar 13, 2026
Collaborator
|
@HVSharma12 please rebase on top of the latest |
1f661ed to
1e67228
Compare
Collaborator
|
[citest] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement: Add openSUSE Leap vars
Reason: Role fails on Leap due to missing vars
Result: Certificate role now works on leap 15
Issue Tracker Tickets (Jira or BZ if any): na
Summary by Sourcery
New Features: