style: Use conscious language for profile list#834
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Jan 8, 2026
Merged
style: Use conscious language for profile list#834richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
Signed-off-by: Till Maas <opensource@till.name>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors variable naming in network_connections.py to use more inclusive and descriptive terminology while preserving existing behavior for selecting which NetworkManager profiles to keep or delete. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- To keep the type of
kept_profilesconsistent across both branches and avoid list vs. set semantics, initialize it as aset()whennameis truthy (instead of[]), since in theelsebranch it is a set and you are using membership checks that are more efficient on sets.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- To keep the type of `kept_profiles` consistent across both branches and avoid list vs. set semantics, initialize it as a `set()` when `name` is truthy (instead of `[]`), since in the `else` branch it is a set and you are using membership checks that are more efficient on sets.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 43.11% 43.22% +0.10%
==========================================
Files 12 12
Lines 3124 3123 -1
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1773 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richm
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change to use more conscious language and more a more meaningful variable name.
Summary by Sourcery
Enhancements: