fix: Modify the background transparency of the account creation screen#3147
fix: Modify the background transparency of the account creation screen#3147leibn123 wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
|
Hi @leibn123. Thanks for your PR. 😃 |
|
Hi @leibn123. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideAdjusts the CreateAccountDialog background to be fully transparent and applies a styled behind-window blur layer that respects light/dark themes and non-blur fallbacks. Flow diagram for blendColor selection in StyledBehindWindowBlurflowchart TD
Start([Start]) --> CheckValid{valid?}
CheckValid -->|Yes| UseBlurColors["DS.Style.control.selectColor(dialog.palette.window,<br>Qt.rgba(1, 1, 1, 0.8),<br>Qt.rgba(0.06, 0.06, 0.06, 0.8))"]
CheckValid -->|No| UseFallbackColors["DS.Style.control.selectColor(undefined,<br>DS.Style.behindWindowBlur.lightNoBlurColor,<br>DS.Style.behindWindowBlur.darkNoBlurColor)"]
UseBlurColors --> End([blendColor set])
UseFallbackColors --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The full-window Rectangle uses hard-coded x/y/width/height offsets based on DS.Style constants; consider using anchors (e.g., anchors.fill with appropriate margins) so the blur layer automatically tracks layout or style changes and window resizes.
- The Rectangle is parented to dialog.contentItem but positioned using dialog.width/height and negative offsets; double-check whether setting the parent to the dialog itself (or anchoring to the contentItem) would be simpler and less fragile than mixing global and content coordinates.
- The new D.DialogTitleBar header overrides any default header; verify that any existing title bar behaviors (buttons, drag, shortcuts) are preserved or explicitly configured to avoid unexpected changes in window controls.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The full-window Rectangle uses hard-coded x/y/width/height offsets based on DS.Style constants; consider using anchors (e.g., anchors.fill with appropriate margins) so the blur layer automatically tracks layout or style changes and window resizes.
- The Rectangle is parented to dialog.contentItem but positioned using dialog.width/height and negative offsets; double-check whether setting the parent to the dialog itself (or anchoring to the contentItem) would be simpler and less fragile than mixing global and content coordinates.
- The new D.DialogTitleBar header overrides any default header; verify that any existing title bar behaviors (buttons, drag, shortcuts) are preserved or explicitly configured to avoid unexpected changes in window controls.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
8555611 to
655aac7
Compare
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
1.修改添加新用户界面的背景透明度问题 PMS: BUG-316577
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leibn123, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 6.1.80 |
|
后续需要在DTK增加一个blur接口去设置模糊, dialogwindow当前的设计只能如此 |
1.修改添加新用户界面的背景透明度问题
Summary by Sourcery
Enhancements: