Skip to content

fix: Modify the background transparency of the account creation screen#3147

Open
leibn123 wants to merge 1 commit intolinuxdeepin:masterfrom
leibn123:master
Open

fix: Modify the background transparency of the account creation screen#3147
leibn123 wants to merge 1 commit intolinuxdeepin:masterfrom
leibn123:master

Conversation

@leibn123
Copy link
Copy Markdown

@leibn123 leibn123 commented Apr 2, 2026

1.修改添加新用户界面的背景透明度问题

Summary by Sourcery

Enhancements:

  • Add a full-window transparent rectangle with behind-window blur to the account creation dialog and set the dialog window color to transparent for consistent themed appearance.

@deepin-ci-robot
Copy link
Copy Markdown

Hi @leibn123. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Copy Markdown

Hi @leibn123. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 2, 2026

Reviewer's Guide

Adjusts the CreateAccountDialog background to be fully transparent and applies a styled behind-window blur layer that respects light/dark themes and non-blur fallbacks.

Flow diagram for blendColor selection in StyledBehindWindowBlur

flowchart TD
  Start([Start]) --> CheckValid{valid?}
  CheckValid -->|Yes| UseBlurColors["DS.Style.control.selectColor(dialog.palette.window,<br>Qt.rgba(1, 1, 1, 0.8),<br>Qt.rgba(0.06, 0.06, 0.06, 0.8))"]
  CheckValid -->|No| UseFallbackColors["DS.Style.control.selectColor(undefined,<br>DS.Style.behindWindowBlur.lightNoBlurColor,<br>DS.Style.behindWindowBlur.darkNoBlurColor)"]
  UseBlurColors --> End([blendColor set])
  UseFallbackColors --> End
Loading

File-Level Changes

Change Details Files
Make the dialog window and its background fully transparent and replace the default background with a custom blurred, theme-aware rectangle.
  • Set the dialog window color to transparent to remove the default opaque background.
  • Add a DialogTitleBar header explicitly referencing the dialog icon.
  • Introduce a full-window Rectangle attached to dialog.contentItem, positioned to cover the entire window including margins and title bar, with transparent fill and z-order behind content.
  • Add a D.StyledBehindWindowBlur inside the Rectangle, filling it and computing blendColor based on blur validity and current palette, with light/dark theme fallbacks when blur is not available.
  • Preserve the original ColumnLayout content and dialog structure with only closing brace formatting adjusted.
src/plugin-accounts/qml/CreateAccountDialog.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The full-window Rectangle uses hard-coded x/y/width/height offsets based on DS.Style constants; consider using anchors (e.g., anchors.fill with appropriate margins) so the blur layer automatically tracks layout or style changes and window resizes.
  • The Rectangle is parented to dialog.contentItem but positioned using dialog.width/height and negative offsets; double-check whether setting the parent to the dialog itself (or anchoring to the contentItem) would be simpler and less fragile than mixing global and content coordinates.
  • The new D.DialogTitleBar header overrides any default header; verify that any existing title bar behaviors (buttons, drag, shortcuts) are preserved or explicitly configured to avoid unexpected changes in window controls.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The full-window Rectangle uses hard-coded x/y/width/height offsets based on DS.Style constants; consider using anchors (e.g., anchors.fill with appropriate margins) so the blur layer automatically tracks layout or style changes and window resizes.
- The Rectangle is parented to dialog.contentItem but positioned using dialog.width/height and negative offsets; double-check whether setting the parent to the dialog itself (or anchoring to the contentItem) would be simpler and less fragile than mixing global and content coordinates.
- The new D.DialogTitleBar header overrides any default header; verify that any existing title bar behaviors (buttons, drag, shortcuts) are preserved or explicitly configured to avoid unexpected changes in window controls.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leibn123 leibn123 force-pushed the master branch 2 times, most recently from 8555611 to 655aac7 Compare April 2, 2026 08:41
}
}
}
} No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一个空行

1.修改添加新用户界面的背景透明度问题

PMS: BUG-316577
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leibn123, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Copy Markdown

deepin-bot bot commented Apr 3, 2026

TAG Bot

New tag: 6.1.80
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3153

@mhduiy
Copy link
Copy Markdown
Contributor

mhduiy commented Apr 3, 2026

后续需要在DTK增加一个blur接口去设置模糊, dialogwindow当前的设计只能如此

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants