Skip to content

chore: [diskencrypt] remove the useless code.#156

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:release/eaglefrom
GongHeng2017:202505161626-eagle-fixPcr
May 20, 2025
Merged

chore: [diskencrypt] remove the useless code.#156
deepin-bot[bot] merged 1 commit intolinuxdeepin:release/eaglefrom
GongHeng2017:202505161626-eagle-fixPcr

Conversation

@GongHeng2017
Copy link
Contributor

@GongHeng2017 GongHeng2017 commented May 16, 2025

-- The code is useless, so remove it.

Log: fix issue

Summary by Sourcery

Enhancements:

  • Abort TPM config generation immediately on algorithm retrieval failure instead of falling back to default values and update log level to critical.

-- The code is useless, so remove it.

Log: fix issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • qWarning()更改为qCritical()可能会影响日志记录和错误处理流程,需要确认这是否符合预期。
  • 当无法选择算法时,直接返回空字符串可能会导致调用者无法处理错误情况,建议抛出异常或返回错误码。

是否建议立即修改:

@sourcery-ai
Copy link

sourcery-ai bot commented May 16, 2025

Reviewer's Guide

Refactor error handling in generateTPMConfig by eliminating fallback defaults and upgrading log severity to fail fast on TPM algorithm selection failure.

File-Level Changes

Change Details Files
Enhanced failure handling for TPM algorithm selection
  • Switched log from qWarning() to qCritical()
  • Removed default hash and key algorithm assignments
  • Inserted early return with empty string on failure
src/dde-file-manager/dfmplugin-disk-encrypt-entry/menu/diskencryptmenuscene.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot
Copy link

deepin-bot bot commented May 20, 2025

This pr cannot be merged! (status: blocked)

@GongHeng2017
Copy link
Contributor Author

/mergeforce

@deepin-bot
Copy link

deepin-bot bot commented May 20, 2025

This pr cannot be merged! (status: blocked)

@GongHeng2017 GongHeng2017 requested review from itsXuSt May 20, 2025 05:47
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, itsXuSt, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 9a3f3fa into linuxdeepin:release/eagle May 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants