fix: resolve crash when stopping plugins#157
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:release/eaglefrom Jun 25, 2025
Merged
fix: resolve crash when stopping plugins#157deepin-bot[bot] merged 1 commit intolinuxdeepin:release/eaglefrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:release/eaglefrom
Conversation
- Fix crash issue caused by translator instance being deleted while qApp still using it - Add .cache and .cursor to .gitignore ignore list Problem: When plugins are stopped, the translator instance is deleted with its parent object, but qApp is still using the instance, causing a crash. Solution: - Optimize translator instance lifecycle management - Ensure translator instance is released after qApp stops using it Task: https://pms.uniontech.com/task-view-378321.html
Reviewer's GuideReparent the QTranslator instance to qApp to prevent premature deletion-related crashes when stopping plugins, and extend .gitignore to exclude .cache and .cursor artifacts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review.gitignore 文件修改
cooperationplugin.cpp 文件修改
总体来说,代码修改应该能够提高代码的可维护性和性能,但需要注意内存管理以及路径配置的正确性。 |
Johnson-zs
approved these changes
Jun 25, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, Johnson-zs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When plugins are stopped, the translator instance is deleted with its parent object,
but qApp is still using the instance, causing a crash.
Solution:
Task: https://pms.uniontech.com/task-view-378321.html
Summary by Sourcery
Prevent crashes when stopping plugins by re-parenting the translator instance to qApp and update .gitignore
Bug Fixes:
Chores: