Skip to content

refactor: move QML registration to factory initialization #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
18202781743 wants to merge 1 commit into from
+7 −5
Closed

refactor: move QML registration to factory initialization #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions dcc-network/operation/dccnetwork.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2024 - 2027 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later
#include "dccnetwork.h"
Expand Down Expand Up @@ -26,10 +26,6 @@ DccNetwork::DccNetwork(QObject *parent)
: QObject(parent)
, m_manager(nullptr)
{
qRegisterMetaType<QList<QVariantMap>>("NMVariantMapList");
qmlRegisterType<NetType>("org.deepin.dcc.network", 1, 0, "NetType");
qmlRegisterType<NetItemModel>("org.deepin.dcc.network", 1, 0, "NetItemModel");
qmlRegisterType<NetManager>("org.deepin.dcc.network", 1, 0, "NetManager");
QMetaObject::invokeMethod(this, "init", Qt::QueuedConnection);
}

Expand Down Expand Up @@ -202,6 +198,12 @@ void DccNetwork::init()
Q_EMIT rootChanged();
}
DCC_FACTORY_CLASS(DccNetwork)
DCC_FACTORY_INITIALIZED([]() {
qRegisterMetaType<QList<QVariantMap>>("NMVariantMapList");
qmlRegisterType<NetType>("org.deepin.dcc.network", 1, 0, "NetType");
qmlRegisterType<NetItemModel>("org.deepin.dcc.network", 1, 0, "NetItemModel");
qmlRegisterType<NetManager>("org.deepin.dcc.network", 1, 0, "NetManager");
})
} // namespace network
} // namespace dde

Expand Down
Loading