Skip to content

Comments

feat: Support mips64 linglong build#574

Merged
lzwind merged 2 commits intolinuxdeepin:masterfrom
dengbo11:feature/mips64-linglong-support
Dec 18, 2025
Merged

feat: Support mips64 linglong build#574
lzwind merged 2 commits intolinuxdeepin:masterfrom
dengbo11:feature/mips64-linglong-support

Conversation

@dengbo11
Copy link
Contributor

Add mips64 linglong.yaml to support build linglong package.

Log: Support build mips64 linglong package.

Add mips64 linglong.yaml to support build linglong package.

Log: Support build mips64 linglong package.
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 26, 2025

TAG Bot

New tag: 6.5.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #576

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 18, 2025

TAG Bot

New tag: 6.5.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #578

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

CLA Assistant Lite bot:

如果你是以企业贡献者的身份进行提交,请联系我们签署企业贡献者许可协议
If you submit as corporate contributor, please contact us to sign our Corporate Contributor License Agreement

感谢您的提交,我们非常感谢。 像许多开源项目一样,在接受您的贡献之前,我们要求您签署我们的个人贡献者许可协议。 您只需发布与以下格式相同的评论即可签署个人贡献者许可协议
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Individual Contributor License Agreement before we can accept your contribution. You can sign the Individual Contributor License Agreement by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA.

You can retrigger this bot by commenting recheck in this Pull Request

@deepin-ci-robot
Copy link

deepin pr auto review

这是一个新添加的linglong.yaml文件,用于构建mips64架构的deepin-manual包。我来对代码进行审查:

  1. 语法逻辑:
  • YAML格式正确,缩进规范
  • 基本配置项完整(version, package, base, runtime等)
  • 构建脚本语法正确
  1. 代码质量:
  • 构建步骤清晰,包括依赖安装、路径修改、构建和部署
  • 使用了变量PREFIX来统一管理安装路径
  • 构建命令使用了并行编译(-jnproc)提高效率
  1. 代码性能:
  • 构建过程合理,没有明显的性能问题
  • 使用了并行编译来加快构建速度
  1. 代码安全:
  • 使用了固定的URL和digest值,确保依赖包的完整性和安全性
  • 构建过程中对路径进行了适当的修改,避免硬编码路径

改进建议:

  1. 构建脚本中的sed命令可以添加错误处理:
if ! sed -i "s|ExecStart=/usr/bin/dman --dbus|ExecStart=dman --dbus|g" $PWD/misc/deepin-manual.service; then
    echo "Failed to modify service file"
    exit 1
fi
  1. 可以在构建前添加依赖检查:
# 检查必要的构建工具
if ! command -v cmake &> /dev/null; then
    echo "cmake is required but not installed"
    exit 1
fi
  1. 建议在构建后添加清理步骤:
# 清理构建文件
rm -rf build
  1. 可以考虑添加构建日志的保存位置:
cmake --build build --target install > "${PREFIX}/install.log" 2>&1
  1. 建议在sources部分添加版本控制,避免使用固定的digest值:
sources:
  - kind: file
    url: https://pools.uniontech.com/desktop-professional-V25/pool/main/q/qt6-tools/assistant-qt6_6.8.0-0deepin3_mips64el.deb
    version: "6.8.0-0deepin3"
    digest: 57fe3a41ae98855bea2f46a967dadb0b7411f2e456a5e19817bf6b446bc36b90
  1. 建议在构建脚本中添加更多的错误处理和状态检查:
# 检查构建是否成功
if [ $? -ne 0 ]; then
    echo "Build failed"
    exit 1
fi
  1. 可以考虑添加构建环境变量的设置:
build: |
  export CC=gcc
  export CXX=g++
  export CFLAGS="-O2"
  export CXXFLAGS="-O2"
  bash ./install_dep linglong/sources "${PREFIX}"
  # ... 其他构建命令
  1. 建议在package部分添加更多的元数据信息:
package:
  id: org.deepin.manual
  name: "deepin-manual"
  version: 6.5.40.1
  kind: app
  description: |
    Manual for deepin OS.
  keywords:
    - manual
    - documentation
    - help
  homepage: https://github.com/linuxdeepin/deepin-manual
  maintainer:
    name: Deepin Team
    email: support@deepin.org

这些改进可以提高构建的可靠性、可维护性和用户体验。

Copy link
Contributor

@lzwind lzwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要处理流水线错误

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengbo11, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit c781194 into linuxdeepin:master Dec 18, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants