fix: Update QTWEBENGINE_CHROMIUM_FLAGS for sw_64 build#585
Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom Jan 20, 2026
Merged
fix: Update QTWEBENGINE_CHROMIUM_FLAGS for sw_64 build#585lzwind merged 1 commit intolinuxdeepin:masterfrom
lzwind merged 1 commit intolinuxdeepin:masterfrom
Conversation
Change the QTWEBENGINE_CHROMIUM_FLAGS environment variable to use --js-flags=--jitless for sw_64 builds, enhancing performance and compatibility. Log: Update QTWEBENGINE_CHROMIUM_FLAGS for sw_64 build. bug: https://pms.uniontech.com/bug-view-347387.html
deepin pr auto review这段代码修改涉及在 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
综合改进建议虽然代码本身语法没有问题,但考虑到性能和安全的平衡,建议在提交代码前考虑以下优化:
#ifdef __sw_64__
// 申威架构下 Chromium 引擎可能存在 JIT 兼容性问题或不稳定,
// 这里启用 jitless 模式以禁用 JIT,确保稳定性并保留沙箱安全机制。
// 注意:这会降低 JS 执行性能。
qputenv("QTWEBENGINE_CHROMIUM_FLAGS", "--js-flags=--jitless");
#endif
总结:该修改在安全性上是正确的方向,但需要警惕性能回退的风险。建议补充注释并进行充分的性能测试。 |
lzwind
approved these changes
Jan 20, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
dengzhongyuan365-dev
added a commit
to dengzhongyuan365-dev/deepin-manual
that referenced
this pull request
Feb 11, 2026
Change the QTWEBENGINE_CHROMIUM_FLAGS environment variable to use --js-flags=--jitless for sw_64 builds, enhancing performance and compatibility. Log: Update QTWEBENGINE_CHROMIUM_FLAGS for sw_64 build. bug: https://pms.uniontech.com/bug-view-347387.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the QTWEBENGINE_CHROMIUM_FLAGS environment variable to use --js-flags=--jitless for sw_64 builds, enhancing performance and compatibility.
Log: Update QTWEBENGINE_CHROMIUM_FLAGS for sw_64 build.
bug: https://pms.uniontech.com/bug-view-347387.html