Skip to content

chore: [tag] New tag 1.5.2#11

Merged
re2zero merged 1 commit intolinuxdeepin:masterfrom
re2zero:bugfix
Apr 22, 2025
Merged

chore: [tag] New tag 1.5.2#11
re2zero merged 1 commit intolinuxdeepin:masterfrom
re2zero:bugfix

Conversation

@re2zero
Copy link
Contributor

@re2zero re2zero commented Apr 22, 2025

Fix CI build and tag v1.5.2 release.

Log: New tag 1.5.2 release.

Fix CI build and tag v1.5.2 release.

Log: New tag 1.5.2 release.
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt 文件修改

    • CMakeLists.txt 文件中,将 find_package(Qt6 COMPONENTS Core Gui QUIET) 放在了 find_package(Qt5 COMPONENTS Core Gui QUIET) 之前,这可能是为了解决高版本 CMake 的问题。但是,这种做法可能会导致在 Qt6 和 Qt5 都未找到时,Qt5 的查找结果被覆盖。建议在 find_package 之前添加一个条件判断,确保 Qt6 和 Qt5 都未找到时再执行 Qt5 的查找。

    改进建议:

    if(NOT Qt6_FOUND)
        find_package(Qt5 COMPONENTS Core Gui QUIET)
    endif()
  2. debian/changelog 文件修改

    • debian/changelog 文件中,新增了一行描述 "both build Qt6 and Qt5",这可能会引起误解,因为通常情况下一个项目不会同时支持两个不同的 Qt 版本。建议明确指出项目是支持 Qt6 的,并且可能需要额外的配置或编译选项来支持 Qt5。

    改进建议:

    deepin-pdfium (1.5.2) unstable; urgency=medium
    
    * Support for Qt6 added.
    * Both Qt6 and Qt5 build support.
    
    -- re2zero <yangwu@uniontech.com>  Tue, 22 Apr 2025 19:42:57 +0800
    
  3. 代码注释

    • CMakeLists.txt 文件中,注释 "查找Qt5和Qt6" 应该更具体地说明查找的顺序和原因,以便其他开发者理解为什么需要先查找 Qt6。

    改进建议:

    # Qt6 must be checked first to avoid issues with high version cmake

总结:

  • 确保在 CMakeLists.txt 中正确处理 Qt6 和 Qt5 的查找顺序,避免潜在的问题。
  • debian/changelog 中明确描述项目的支持情况,避免混淆。
  • 优化注释,使代码更易于理解和维护。

@github-actions
Copy link

TAG Bot

TAG: 1.5.2
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero re2zero merged commit acac5c3 into linuxdeepin:master Apr 22, 2025
18 checks passed
@re2zero re2zero deleted the bugfix branch April 22, 2025 12:38
@re2zero re2zero restored the bugfix branch April 23, 2025 01:04
@re2zero re2zero deleted the bugfix branch April 23, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants