Skip to content

fix: optimize handling of remote PDF files#12

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master
Apr 29, 2025
Merged

fix: optimize handling of remote PDF files#12
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

Improves the way the application handles PDF files located on remote filesystems like SMB:

  1. Add detection of remote files using filesystem type checking
  2. Create local copies of remote files in a dedicated cache directory
  3. Implement a new save strategy for remote files:
    • Avoid file deletion which causes issues on SMB filesystems
    • Use saveAs() method to directly write to destination

Log: Added support for handling remote files and saving them appropriately.

bug: https://pms.uniontech.com/bug-view-314071.html

Improves the way the application handles PDF files located on remote filesystems like SMB:

1. Add detection of remote files using filesystem type checking
2. Create local copies of remote files in a dedicated cache directory
3. Implement a new save strategy for remote files:
   - Avoid file deletion which causes issues on SMB filesystems
   - Use saveAs() method to directly write to destination

Log: Added support for handling remote files and saving them appropriately.

bug: https://pms.uniontech.com/bug-view-314071.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • isRemoteFile函数中,QStorageInfo的使用可能不适用于所有平台,因为不是所有平台都支持QStorageInfo
  • saveLocalFilesaveRemoteFile函数中,临时文件的处理逻辑可能需要改进,以确保在所有情况下都能正确删除临时文件。
  • save函数中,对于远程文件的处理逻辑可能需要更详细的错误处理,以应对文件保存过程中可能出现的各种问题。
  • save函数中,对于本地文件的处理逻辑可能需要更详细的错误处理,以应对文件保存过程中可能出现的各种问题。
  • save函数中,对于远程文件的处理逻辑可能需要更详细的错误处理,以应对文件保存过程中可能出现的各种问题。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dengzhongyuan365-dev
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Apr 29, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit aaefb87 into linuxdeepin:master Apr 29, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants