chore: Adjusted build and packaging strategy#22
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Nov 26, 2025
Merged
chore: Adjusted build and packaging strategy#22deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
Contributor
wangrong1069
commented
Nov 25, 2025
- Prefers Qt6 for building and packaging; both Qt5 and Qt6 are no longer supported simultaneously.
- Uses the same package name when building based on Qt5 and Qt6.
- Prefers Qt6 for building and packaging; both Qt5 and Qt6 are no longer supported simultaneously. - Uses the same package name when building based on Qt5 and Qt6.
deepin pr auto review我来分析一下这个 Git diff 的变更:
优点:
潜在问题:
优点:
优点:
改进建议:
# 建议添加版本检查
if(Qt6_FOUND)
if(Qt6_VERSION VERSION_LESS "6.2.0")
message(WARNING "Qt6 version < 6.2.0 may have compatibility issues")
endif()
set(QT_DESIRED_VERSION 6)
else()
if(Qt5_VERSION VERSION_LESS "5.12.0")
message(WARNING "Qt5 version < 5.12.0 may have compatibility issues")
endif()
set(QT_DESIRED_VERSION 5)
endif()
# 添加错误检查
if(NOT Qt6_FOUND AND NOT Qt5_FOUND)
message(FATAL_ERROR "Neither Qt5 nor Qt6 found")
endif()
这些变更整体上是合理的,简化了项目结构,但需要注意保持足够的灵活性和兼容性。建议在实施这些更改后,进行充分的测试,确保在不同环境下的正常工作。 |
lzwind
approved these changes
Nov 26, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.