fix: personalization resource destroy callbacks had inverted null check

[felixonmars]

All 4 wl_resource destroy callbacks in personalization_manager_impl.cpp had an inverted null check introduced by commit 56c8376:

    if (resource)   // always true in a destroy callback
        return;     // function returns immediately, doing nothing

    wl_list_remove(...)  // never reached
    delete context;      // never reached

This meant wl_list_remove was never called, leaving freed wl_resource objects as dangling links in manager->resources. When a Wayland client disconnects, wl_client_destroy frees the resource memory while stale links remain in the list. Subsequent wl_list_insert/wl_list_remove operations on the same list then write to freed memory, corrupting the heap and causing crashes.

Fix by inverting the check to if (!resource).

Summary by Sourcery

Bug Fixes:

• Correct wl_resource destroy callbacks for personalization window, wallpaper, cursor, and manager contexts so their cleanup logic runs as intended when resources are destroyed.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes inverted null checks in all four Wayland personalization wl_resource destroy callbacks so that cleanup code (list removal and context deletion) now runs correctly and avoids heap corruption from dangling list links.

Sequence diagram for wl_resource destroy callback fix

sequenceDiagram
    participant WaylandClient
    participant wl_client as wl_client
    participant wl_resource as wl_resource
    participant Manager as treeland_personalization_manager_v1

    WaylandClient->>wl_client: disconnect()
    wl_client->>wl_resource: wl_resource_destroy(resource)
    wl_resource->>Manager: treeland_personalization_manager_resource_destroy(resource)
    alt resource_is_null
        Manager-->>Manager: return
    else resource_is_not_null
        Manager->>Manager: treeland_personalization_manager_v1.from_resource(resource)
        Manager->>Manager: wl_list_remove(resource_link)
        Manager->>Manager: delete context
    end

Loading

Flow diagram for corrected null check in destroy callbacks

flowchart TD
    A[wlr_destroy_callback called with resource] --> B{resource is null?}
    B -- Yes --> C[Return immediately]
    B -- No --> D[Lookup context via from_resource]
    D --> E[Remove resource from manager resources list]
    E --> F[Delete context object]
    F --> G[Return from destroy callback]

Loading

File-Level Changes

Change	Details	Files
Correct the null-check condition in all personalization wl_resource destroy callbacks so they early-return only on null resources and perform proper cleanup otherwise.	Invert the condition in personalization_window_context_resource_destroy so it returns only when the wl_resource pointer is null. Invert the condition in personalization_wallpaper_context_resource_destroy so it returns only when the wl_resource pointer is null. Invert the condition in personalization_cursor_context_resource_destroy so it returns only when the wl_resource pointer is null. Invert the condition in treeland_personalization_manager_resource_destroy so it returns only when the wl_resource pointer is null, ensuring manager lookup and cleanup are executed.	src/modules/personalization/impl/personalization_manager_impl.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since Wayland destroy callbacks are not invoked with a null wl_resource, consider either removing the null check entirely or replacing it with an assertion to make the intended invariant explicit.
• All four destroy callbacks share identical null-check and cleanup patterns; consider factoring this into a small helper or template to reduce duplication and avoid this class of inverted-condition bug in the future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since Wayland destroy callbacks are not invoked with a null wl_resource, consider either removing the null check entirely or replacing it with an assertion to make the intended invariant explicit.
- All four destroy callbacks share identical null-check and cleanup patterns; consider factoring this into a small helper or template to reduce duplication and avoid this class of inverted-condition bug in the future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}