Skip to content

EXTRA_QT_PLUGINS is a bit misleading #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asl opened this issue Aug 24, 2022 · 0 comments · Fixed by #174
Closed

EXTRA_QT_PLUGINS is a bit misleading #121

asl opened this issue Aug 24, 2022 · 0 comments · Fixed by #174
Labels
help wanted Extra attention is needed

Comments

@asl
Copy link
Contributor

asl commented Aug 24, 2022

Actually EXTRA_QT_PLUGINS name is a bit misleading, it should actually be EXTRA_QT_MODULES.

I think this was just taken over from linuxdeployqt. We should think about correcting this. Mind to open an issue?

Originally posted by @TheAssassin in #118 (comment)
@TheAssassin TheAssassin added the help wanted Extra attention is needed label Dec 10, 2023
@dantti dantti mentioned this issue Jun 12, 2024
Merged
dantti added a commit to dantti/linuxdeploy-plugin-qt that referenced this issue Jun 12, 2024
@dantti
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES
7f77ae6 
Fixes: linuxdeploy#121
dantti added a commit to dantti/linuxdeploy-plugin-qt that referenced this issue Jun 12, 2024
@dantti
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES
3f5c1fb 
Fixes: linuxdeploy#121
dantti added a commit to dantti/linuxdeploy-plugin-qt that referenced this issue Jun 16, 2024
@dantti
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES
d65cb3a 
Fixes: linuxdeploy#121
dantti added a commit to dantti/linuxdeploy-plugin-qt that referenced this issue Jun 18, 2024
@dantti
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES
05727cd 
Fixes: linuxdeploy#121
dantti added a commit to dantti/linuxdeploy-plugin-qt that referenced this issue Jun 19, 2024
@dantti
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES
12bd813 
Fixes: linuxdeploy#121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES dantti/linuxdeploy-plugin-qt
2 participants
@asl @TheAssassin