-
Notifications
You must be signed in to change notification settings - Fork 40
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheAssassin
merged 1 commit into
linuxdeploy:master
from
dantti:dantti/rename_extra_plugins
Aug 2, 2024
Merged
Rename EXTRA_QT_PLUGINS to EXTRA_QT_MODULES #174
TheAssassin
merged 1 commit into
linuxdeploy:master
from
dantti:dantti/rename_extra_plugins
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantti
commented
Jun 12, 2024
7f77ae6
to
3f5c1fb
Compare
TheAssassin
reviewed
Jun 12, 2024
Applying your suggestion through github created a new commit, are you fine with squashing it or prefer that I do it? |
Feel free to squash the changes. |
TheAssassin
reviewed
Jun 16, 2024
32afd35
to
d65cb3a
Compare
bjorn
reviewed
Jun 17, 2024
d65cb3a
to
05727cd
Compare
bjorn
approved these changes
Jun 19, 2024
05727cd
to
12bd813
Compare
TheAssassin
approved these changes
Aug 2, 2024
Thanks! And sorry for the long delay. I've been really busy lately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #121