Skip to content

Add instructions on how to build to the README. #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

camilasan
Copy link
Contributor

@camilasan camilasan commented Sep 19, 2024

This PR adds instructions on how to build the project to the README.

@camilasan
Copy link
Contributor Author

@TheAssassin my PR is not valid? Should I close it?

Copy link
Contributor

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving some comments. I have not verified the instructions.

- [patchelf](https://github.com/NixOS/patchelf)
- [cimg](https://cimg.eu/)
- optional - disable it with `USE_CCACHE` cmake var: [ccache](https://ccache.dev/)
2. [Fork this repository and clone it](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you suggest to fork the repository just to build it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you suggest to fork the repository just to build it?

If you want to contribute to the project, that is how you do it.
Only people with access to the repo don't need to fork.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that was my point with this line, I could also remove it.

Co-authored-by: Thorbjørn Lindeijer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants