-
Notifications
You must be signed in to change notification settings - Fork 40
Add instructions on how to build to the README. #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c5af6e1
to
3c358b6
Compare
3c358b6
to
36b6d82
Compare
@TheAssassin my PR is not valid? Should I close it? |
36b6d82
to
37d273a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving some comments. I have not verified the instructions.
- [patchelf](https://github.com/NixOS/patchelf) | ||
- [cimg](https://cimg.eu/) | ||
- optional - disable it with `USE_CCACHE` cmake var: [ccache](https://ccache.dev/) | ||
2. [Fork this repository and clone it](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you suggest to fork the repository just to build it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you suggest to fork the repository just to build it?
If you want to contribute to the project, that is how you do it.
Only people with access to the repo don't need to fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that was my point with this line, I could also remove it.
Co-authored-by: Thorbjørn Lindeijer <[email protected]>
This PR adds instructions on how to build the project to the README.