Readme example of bindings within celery tasks example, Support for channels v1.x#43
Open
mattyg wants to merge 4 commits intolinuxlewis:masterfrom
Open
Readme example of bindings within celery tasks example, Support for channels v1.x#43mattyg wants to merge 4 commits intolinuxlewis:masterfrom
mattyg wants to merge 4 commits intolinuxlewis:masterfrom
Conversation
mattyg
changed the title
Contributor
|
Maybe this can then be the basis for the last proper release for channels 1.x. |
Owner
|
I would move the celery example out of the getting started. It's technically not required. I've fixed the package requirements on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks so much for this project! It was extremely helpful and the missing piece I was searching for!
I updated the Readme to include how to get model bindings to work with model instances within celery tasks.
I also updated the Reame and requirements.txt to indicate support for only channels 1.x, until #42 is resolved.