Add Brave search engine to Homepage Search#1438
Closed
NoX1De wants to merge 1 commit intolinuxserver:2.xfrom
Closed
Add Brave search engine to Homepage Search#1438NoX1De wants to merge 1 commit intolinuxserver:2.xfrom
NoX1De wants to merge 1 commit intolinuxserver:2.xfrom
Conversation
Author
|
@KodeStar tagging you to see if you could review/approve if at all possible when you have a chance, it is much appreciated! |
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Bumping this again @KodeStar @keriati @laravel-shift Anyone can check/merge this plz? |
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Hello, anyone there? : ) |
|
This pull request is locked due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'd like to add Brave search engine to the Homepage Search. I haven't updated all of the
/lang/*/app.phpfiles to include the'options.brave' => 'Brave',line, just the english file, but this should get the base functionality into place.