[Feat] Allow override of GUI's listen address from Syncthing configuration file or environs #98
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
Nementon
force-pushed
the
feat/override-gui-listen-addr-from-config-or-envs
branch
from
b33b028 to
e94bc17
Compare
|
I am a bot, here are the test results for this PR:
|
Nementon
force-pushed
the
feat/override-gui-listen-addr-from-config-or-envs
branch
2 times, most recently
from
751ff49 to
fdf7cbf
Compare
|
I am a bot, here are the test results for this PR:
|
|
Alternatively, as I'm discovering the LinuxServer ecosystem, I've made an equivalent mod for it: https://github.com/Nementon/docker-mods/tree/syncthing-guiaddress-override If your interested about it but prefere to have a dedicated mod rather than to include it in the base image, kindly create the dedicated branch and let me know, I will proceed to make a PR on https://github.com/linuxserver/docker-mods. |
Nementon
force-pushed
the
feat/override-gui-listen-addr-from-config-or-envs
branch
2 times, most recently
from
a460572 to
f9f6774
Compare
configuration file or environs
- Replace hardcoded default listen address `0.0.0.0:8384` with
1. Environment variables lookup
a. From `STGUIADDRESS` (eg: `0.0.0.0:4242`)
b. From `STGUIHOST` (eg: `0.0.0.0`) and/or STGUIPORT (eg: `4242`)
2. Static configuration lookup from Syncthing config.xml
3. Default to `0.0.0.0` and `8384`
Nementon
force-pushed
the
feat/override-gui-listen-addr-from-config-or-envs
branch
from
f9f6774 to
3525e14
Compare
|
I am a bot, here are the test results for this PR:
|
2 participants
Description:
This PR replaces the hardcoded default GUI listen address
--gui-address=0.0.0.0:8384with a lookup sequence:STGUIADDRESS(eg:0.0.0.0:4242)STGUIHOST(eg:0.0.0.0) and/or STGUIPORT (eg:4242)0.0.0.0and8384Benefits of this PR and context:
After updating the container to the latest version, it was no longer possible to override the
--gui-address=0.0.0.0:8384command argument during initialization, which broke my deployment setup.This PR introduces a flexible mechanism to control the GUI listening host and port, which is useful for deployments with race conditions or setups requiring custom configuration of the GUI endpoint.
How Has This Been Tested?
docker build --no-cache --pull -t lscr.io/linuxserver/syncthing:latest .0.0.0.0:8384config.xmlto changegui.address, then restarting the container correctly applies the configured values<address>127.0.0.1:4242</address>->--gui-address=127.0.0.1:4242<adress>:4242<address>->--gui-address=0.0.0.0:4242<address> :80 </address>->--gui-address=0.0.0.0:80This PR introduces no breaking changes.
Source / References: