Discount bandit #719
Open
Discount bandit #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from linuxserver:master
[pull] master from linuxserver:master
[pull] master from linuxserver:master
Signed-off-by: Joseph Harry <[email protected]>
|
I do not think the error is with my pull. |
[pull] master from linuxserver:master
pagdot
suggested changes
Nov 26, 2024
|
The Check Samples is failing on error pages not related to the pull |
|
You might want to do a proper rebase and force push. A brand new PR passes the conf validity check: #723 Also, please remove the |
|
hold on, I take it back You double included the proxy.conf in the subfolder.conf.sample |
drizuid
requested changes
Dec 21, 2024
Signed-off-by: Joseph Harry <[email protected]>
drizuid
approved these changes
Dec 26, 2024
Signed-off-by: Joseph Harry <[email protected]>
Signed-off-by: Joseph Harry <[email protected]>
Signed-off-by: Joseph Harry <[email protected]>
Signed-off-by: Joseph Harry <[email protected]>
Signed-off-by: Joseph Harry <[email protected]>
create conf file
Signed-off-by: Joseph Harry <[email protected]>
…confs into discount-bandit
Signed-off-by: Joseph Harry <[email protected]>
|
I am mostly sure I did the rebase correctly. Crazy how many things change with this repo while I was fixing the mistakes. |
|
I have completed it with e2b2c6c |
This comment was marked as off-topic.
This comment was marked as off-topic.
drizuid
requested changes
Jan 11, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as abuse.
This comment was marked as abuse.
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for discount-bandit
Description
Benefits of this PR and context
How Has This Been Tested?
I am using this in my homelab right now.
Source / References