Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create davis.subdomain.conf.sample #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unkn0wnAPI
Copy link
Contributor

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description

Adds reverse proxy configuration for tchapi/davis docker container.

Benefits of this PR and context

Adds missing reverse proxy configuration for tchapi/davis docker container.

How Has This Been Tested?

This configuration has been tested by me, after incorporating davis calendar docker container into my homelab environment.
Steps used to test the configuration:

  1. Create and start davis docker container;
  2. Add this configuration file to proxy-confs swag directory and remove .sample suffix;
  3. Set davis CNAME in your DNS provider configuration panel (Cloudflare was used during testing);
  4. Restart both swag and davis docker container;
  5. Access davis container by navigating to https://davis.your-domain.tld;

Source / References

Davis Github Project

Nginx reverse proxy configuration for davis calendar [tchapi/davis]
@@ -0,0 +1,61 @@
## Version 2025/01/15
# make sure that your davis container is named davis
# make sure that your dns has a cname set for davis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a note about the official container having standard and standalone versions, the standalone indeed exposes port 9000 but the standard compose seems to include nginx which maps 9000 on the host to 80 on the container, meaning that it would require set $upstream_port 80;.

}

# Required for autodiscovery
rewrite ^/.well-known/caldav /dav/ redirect;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the rewrites above the location brackets, or put them in a location bracket the same way we have it in https://github.com/linuxserver/docker-nextcloud/blob/master/root/defaults/nginx/site-confs/default.conf.sample#L89

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants