Update PiHole V6 /api subdomain
#751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that this solution solved the same issue I was facing after upgrading Pi-hole. Thanks! |
|
Worked for me :) I was not able to login on pihole via swag/nginx since I upgraded to v6. Uncommenting the lines on this PR fixed my issue |
that1matt
force-pushed
the
fix-pihole-v6-api
branch
from
73b17d9 to
095ca4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating to PiHole v6 using a subdomain, caused 500 errors when trying to load the queries page, or make API calls.
Benefits of this PR and context
This change allows for PiHole v6+ to continue to work behind a subdomain reverse proxy.
How Has This Been Tested?
With the current setup, when accessing
/admin/queriesor theQuery Logtab on the right, you would get a pop up showing an error.With this new
/apiblock, theQuery Logloads as expected.Source / References
PiHole v6 Release Notes