build: refactor container build process #3403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: fix pipeline
line string goes here
blacha
added
container
|
containers are unable to be pushed as this is from a basemaps fork 😭 I wonder if there is a better way of handling building containers when building off a public fork. |
tawera-manaena
previously approved these changes
Feb 19, 2025
tawera-manaena
approved these changes
Feb 19, 2025
auto-merge was automatically disabled
February 19, 2025 21:33
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug building
arm64containers underamd64which is causing segfaults, we currently use QEMU to cross compile the containers which can be reasonably slow.There is also another bug where external contributors cannot trigger builds on pull requests to basemaps which leaves pull requests unable to be merged. eg: #3396
The build process for containers was also split across two workflows this merges the workflows into a single container building workflow.
Modifications
Disable build pipelines for external pull requests as they do not have access to our secrets, which causes them to fail.
Split container builds into a matrix build using arm64 runners for arm containers and amd64 runners for x86 containers.
Verification
Created a number of containers with
containertag on pull requests and pushed commits to the master branch onblacha/basemaps