fix: use the configuration version not time to reset cache #3553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Loading a huge amount of tiffs to compile a configuration takes a long time in some cases 30+ minutes, when recompiling these configs as part of pull requests parts of the config can be cached so every individual tiff file does not need to be loaded.
We current store that cache for a month and reset it on the first of the month, there is nothing stopping us storing that cache for longer as the first pull requests of the month take a long time to process as they are starting from a cold cache.
Modifications
Move the cache to only reset if a configuration change has been detected.
Verification
Unit tests/run locally