feat: move Postgres family to clientless validation - #142
Open
cofin wants to merge 3 commits into
Open
Conversation
cofin
force-pushed
the
feat/clientless-postgres-family
branch
from
July 21, 2026 17:13
e313e78 to
c51332f
Compare
cofin
force-pushed
the
feat/clientless-postgres-family
branch
2 times, most recently
from
July 22, 2026 05:08
c442a11 to
2131efc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/provider-aware-ci #142 +/- ##
========================================================
Coverage ? 6.43%
========================================================
Files ? 22
Lines ? 1724
Branches ? 139
========================================================
Hits ? 111
Misses ? 1590
Partials ? 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Drop the runtime psycopg dependency from the postgres extra. The PostgresService fixtures now validate readiness and create the per-worker database through `psql` invoked via container.exec_run, and the bundled *_connection fixtures (postgres, pgvector, paradedb, alloydb_omni) are removed. Users install their own psycopg client alongside pytest-databases[postgres]. The _make_connection_string helper stays — cockroachdb tests still import it as a pure string formatter.
The postgres official image runs a two-phase boot: phase 1 listens on the Unix socket only for initdb, phase 5 restarts with TCP listeners. Calling psql without -h opportunistically uses the socket and the readiness check could pass during phase 1, leaving _create_worker_database to find the socket gone (or never present) after phase 5. Pinning -h localhost -p 5432 forces psql onto the same TCP transport user code uses, so readiness ≡ "TCP ready". Surfaced as a flaky postgres_14_service failure on the Python 3.14 shard.
cofin
force-pushed
the
feat/clientless-postgres-family
branch
from
July 22, 2026 15:56
2131efc to
61d52a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
psycopgfrom thepytest-databases[postgres]extra. Thepostgres,pgvector,paradedb, andalloydb_omnifixtures (and every per-version variant) now check readiness and create per-worker databases through the bundledpsqlCLI.All bundled
*_connectionfixtures are removed. Users install their ownpsycopgclient alongsidepytest-databasesand build connections from the service metadata._make_connection_stringstays — it's a pure string formatter still imported elsewhere. The[postgres]extra is now empty;cockroachdbstill pullspsycopg, and the devextragroup keepspsycopg[binary,pool].