Skip to content

A couple minor fixes #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chess123mate wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A couple minor fixes #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6368ba
Allow state to remain unchanged in combineActions
chess123mate Jul 1, 2024
5f9fd16
Fix bug with nested observes
chess123mate Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/combineProducers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,18 @@ local function combineActions(producers: types.ProducerMap)

for actionName, actions in actionsByName do
combinedActions[actionName] = function(combinedState, ...)
local nextState = table.clone(combinedState)
local nextState

for _, action in actions do
local producerName = producerNamesByAction[action]
local producerState = nextState[producerName]
nextState[producerName] = action(producerState, ...)
local producerState = combinedState[producerName]
local newState = action(producerState, ...)
if newState == producerState then continue end
if not nextState then nextState = table.clone(combinedState) end
nextState[producerName] = newState
end

return nextState
return nextState or combinedState
end
end

Expand Down
18 changes: 10 additions & 8 deletions src/utils/createSelectArrayDiffs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,19 @@ local function createSelectArrayDiffs<State, K, V>(
local deletions: { Entry<K, V> } = {}
local entries: { [unknown]: Entry<K, V> } = {}

for key, item in items do
local id = if discriminator then discriminator(item, key) else item
local entry = { key = key, value = item, id = id }
if items then
for key, item in items do
local id = if discriminator then discriminator(item, key) else item
local entry = { key = key, value = item, id = id }

assert(id ~= nil, "Discriminator returned a nil value")
assert(id ~= nil, "Discriminator returned a nil value")

if not lastEntries[id] then
table.insert(additions, entry)
end
if not lastEntries[id] then
table.insert(additions, entry)
end

entries[id] = entry
entries[id] = entry
end
end

for id, item in lastEntries do
Expand Down