Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative line numbers in code editors #712

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

hatemhosny
Copy link
Collaborator

@hatemhosny hatemhosny commented Jan 11, 2025

What type of PR is this? (check all applicable)

  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • ♻️ Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert
  • 🌐 Internationalization / Translation

Description

This PR allows relative line numbers in code editors (Monaco and CodeMirror).
the configuration option lineNumbers can now have any of the values: true, false or "relative"

This option can be set in the UI from the editor settings screen.

image

image

image

Thank you @Mohmed-Refaay for the suggestion.

Copy link

netlify bot commented Jan 11, 2025

βœ… Deploy Preview for livecodes ready!

Name Link
πŸ”¨ Latest commit c88ad99
πŸ” Latest deploy log https://app.netlify.com/sites/livecodes/deploys/6782797d7969980009001b5a
😎 Deploy Preview https://deploy-preview-712--livecodes.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hatemhosny hatemhosny merged commit fd39ed9 into develop Jan 11, 2025
19 checks passed
Copy link
Contributor

livecodes-ci bot commented Jan 11, 2025

i18n Actions

Source PR has been merged into the default branch.

Maintainers can comment .i18n-update-push to trigger the i18n update workflow and push the changes to Lokalise.

@hatemhosny
Copy link
Collaborator Author

.i18n-update-push

Copy link
Contributor

livecodes-ci bot commented Jan 11, 2025

i18n Actions: .i18n-update-push

Localization updated and pushed to Lokalise.

Name Description
New Branch for i18n i18n/live-codes/relative-line-numbers
Last Commit SHA fd39ed9

Maintainers can comment .i18n-update-pull after translation is done to trigger the i18n pull workflow and pull the changes back to Github.

@hatemhosny
Copy link
Collaborator Author

.i18n-update-pull

Copy link
Contributor

livecodes-ci bot commented Jan 11, 2025

i18n Actions: .i18n-update-pull

Localization pulled from Lokalise.

Name Description
i18n Branch i18n/live-codes/relative-line-numbers
Last Commit SHA 17b9e0b
i18n PR #713

@hatemhosny hatemhosny deleted the relative-line-numbers branch January 11, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant