Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor mode fixes #715

Merged
merged 6 commits into from
Jan 14, 2025
Merged

editor mode fixes #715

merged 6 commits into from
Jan 14, 2025

Conversation

hatemhosny
Copy link
Collaborator

@hatemhosny hatemhosny commented Jan 13, 2025

What type of PR is this? (check all applicable)

  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • ♻️ Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert
  • 🌐 Internationalization / Translation

Description

This PR fixes some bugs related to editor mode:

  • on changing mode (using SDK) from editor mode to result mode, the compiler is not available.
  • hide result toggle button in editor mode
  • fix duplicate playground if the SDK method createPlayground was called multiple times (e.g. react re-renders)
  • fix default theme color (on logging out)
  • reset element styles before changing mode

Copy link

netlify bot commented Jan 13, 2025

βœ… Deploy Preview for livecodes ready!

Name Link
πŸ”¨ Latest commit 4da8bcd
πŸ” Latest deploy log https://app.netlify.com/sites/livecodes/deploys/6786d53856995600089453ba
😎 Deploy Preview https://deploy-preview-715--livecodes.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2025

Deploying livecodes with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 4da8bcd
Status:Β βœ…Β  Deploy successful!
Preview URL: https://71553522.livecodes.pages.dev
Branch Preview URL: https://fix-editor-mode.livecodes.pages.dev

View logs

Copy link

@hatemhosny hatemhosny merged commit e248377 into develop Jan 14, 2025
17 checks passed
@hatemhosny hatemhosny deleted the fix-editor-mode branch January 14, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant