-
Notifications
You must be signed in to change notification settings - Fork 473
Introducing the new Apps page #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I am not sure I like the style where we have a blue background with some white areas. As far as I know, we don't do this anywhere in Livebook. We could leave it all white, but then it can get confused with an actual app. So my suggestion is to keep the modal, but make it almost full screen (90% for example). |
@josevalim why a modal? We use a modal for starting multi-session app session, but we show the app skeleton in the background, so a modal works. Here it feels weird to me, because there is nothing behind the modal. To me a flat page is much cleaner (i.e. with white background, not gray one). |
Agree. This new "modal"-based UI felt a little bit weird for me as well. |
|
The code looks good to me! I would only remove the modal, up to @josevalim :) |
|
@aleDsz I have explained my rationale to @hugobarauna and he will make a decision. If we go with the modal, I only propose to change the "no apps found" to use all height available (and therefore be centralized). |
When there's no apps running:
When there's no apps running, but it has
apps_pathconfigured:When it has apps:
When it has too many apps:
When it has apps, but didn't found any app with the filter criteria: