Skip to content

Conversation

@aleDsz
Copy link
Member

@aleDsz aleDsz commented Nov 6, 2025

When there's no apps running:

image

When there's no apps running, but it has apps_path configured:

image

When it has apps:

image

When it has too many apps:

image

When it has apps, but didn't found any app with the filter criteria:

image

@aleDsz aleDsz self-assigned this Nov 6, 2025
@josevalim
Copy link
Contributor

I am not sure I like the style where we have a blue background with some white areas. As far as I know, we don't do this anywhere in Livebook. We could leave it all white, but then it can get confused with an actual app.

So my suggestion is to keep the modal, but make it almost full screen (90% for example).

@jonatanklosko
Copy link
Member

So my suggestion is to keep the modal, but make it almost full screen (90% for example).

@josevalim why a modal? We use a modal for starting multi-session app session, but we show the app skeleton in the background, so a modal works. Here it feels weird to me, because there is nothing behind the modal. To me a flat page is much cleaner (i.e. with white background, not gray one).

@hugobarauna
Copy link
Member

So my suggestion is to keep the modal, but make it almost full screen (90% for example).

@josevalim why a modal? We use a modal for starting multi-session app session, but we show the app skeleton in the background, so a modal works. Here it feels weird to me, because there is nothing behind the modal. To me a flat page is much cleaner (i.e. with white background, not gray one).

Agree. This new "modal"-based UI felt a little bit weird for me as well.

@aleDsz aleDsz requested a review from jonatanklosko November 10, 2025 19:44
@jonatanklosko
Copy link
Member

The code looks good to me! I would only remove the modal, up to @josevalim :)

@josevalim
Copy link
Contributor

@aleDsz I have explained my rationale to @hugobarauna and he will make a decision. If we go with the modal, I only propose to change the "no apps found" to use all height available (and therefore be centralized).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants