-
Notifications
You must be signed in to change notification settings - Fork 1.5k
use inference gateway in the readme #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theomonnom
wants to merge
1
commit into
main
Choose a base branch
from
theo/update-readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -99,9 +99,9 @@ async def entrypoint(ctx: JobContext): | |||||
| session = AgentSession( | ||||||
| vad=silero.VAD.load(), | ||||||
| # any combination of STT, LLM, TTS, or realtime API can be used | ||||||
| stt=deepgram.STT(model="nova-3"), | ||||||
| llm=openai.LLM(model="gpt-4o-mini"), | ||||||
| tts=elevenlabs.TTS(), | ||||||
| stt="assemblyai/universal-streaming:en", | ||||||
| llm="openai/gpt-4.1-mini", | ||||||
| tts="cartesia/sonic-2:9626c31c-bec5-4cca-baa8-f8ba9e84c8bc", | ||||||
| ) | ||||||
|
|
||||||
| await session.start(agent=agent, room=ctx.room) | ||||||
|
|
@@ -177,9 +177,9 @@ async def entrypoint(ctx: JobContext): | |||||
| userdata = StoryData() | ||||||
| session = AgentSession[StoryData]( | ||||||
| vad=silero.VAD.load(), | ||||||
| stt=deepgram.STT(model="nova-3"), | ||||||
| llm=openai.LLM(model="gpt-4o-mini"), | ||||||
| tts=openai.TTS(voice="echo"), | ||||||
| stt="deepgram/nova-3", | ||||||
| llm="openai/gpt-4o", | ||||||
| tts="elevenlabs/eleven_turbo_v2_5:Xb7hH8MSUJpSbSDYk0k2", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| userdata=userdata, | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're recommending
openai/gpt-4.1.minias the new defaultUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model hallucinates a lot, can't get the drive-thru tests to pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh we should probably not be using it as default then - will revive the convo in slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcherry @theomonnom I can't find the slack thread where you're discussing what the default should be. Looks like you landed on 4o. Should we have the examples and the quickstart also use 4o by default?
When we were talking about this for the gateway before launching, I remember DZ saying we should use 4.1 bc OAI will eventually deprecate 4o. But I was also just talking to a user who said, "4o 2024-05-13 is better at tool calling, and oai models are not robotic, and the intelligence doesn’t drop with large context, all for the best trade off on latency. 4.1 and gemini 2.5 flash comes close, but the may version of 4o is the best. They even charge more for it." Lots of users have different preferences, but it was interesting to hear this guy back up what he likes about 4o, and specify the may version specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i posted in slack but got no replies on it https://live-kit.slack.com/archives/C05P6DRC6MV/p1760744284787699
I don't have an opinion, happy to do whatever the team thinks is the right answer but want to be consistent across the board and also get this PR landed!