format transcript logs #3708
Open
format transcript logs #3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulwe
commented
Oct 23, 2025
| "type": item.type, | ||
| "id": item.id, | ||
| "role": item.role, | ||
| "content": [content for content in item.content if isinstance(content, str)], |
There was a problem hiding this comment.
should we include summaries of the non-text content? dropping this might remove useful context
|
I think we should use the JSON protobuf instead of arbitrary json |
|
like? |
empty value is raising an error
paulwe
commented
Oct 24, 2025
Comment on lines
306
to
266
|
|
||
| def _to_rfc3339(value: int | float | datetime) -> str: |
There was a problem hiding this comment.
this should be chat_history
| }, | ||
| ) | ||
| chat_logger.emit( | ||
| LogRecord( |
There was a problem hiding this comment.
please include the options. this context may be useful for debugging
| "name": item.name, | ||
| "call_id": item.call_id, | ||
| "output": output, | ||
| "is_error": item.is_error, |
There was a problem hiding this comment.
we can remove the created_at key. it's already in the log ts
| header_msg = proto_metrics.MetricsRecordingHeader( | ||
| room_id=room_id, | ||
| enable_user_data_training=report.enable_user_data_training | ||
| room_id=room_id, enable_user_data_training=report.enable_user_data_training |
There was a problem hiding this comment.
we should also upload this in the report format for training/long term storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.