-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Chore: AssemblyAI add dynamic keyterms + return language code + normalize preemptive generation validation #3802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dan-ince-aai
wants to merge
11
commits into
livekit:main
Choose a base branch
from
dan-ince-aai:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−7
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4bbde1a
chore: return language code + dynamic keyterms
dan-ince-aai 719fded
chore: normalize preemptive generation text before validation
dan-ince-aai 82d8359
chore: store language code from utterance for final transcript
dan-ince-aai 425404e
ruff
dan-ince-aai cc24d1d
type checks
dan-ince-aai 2676b6c
type check fix
dan-ince-aai 5c7ce7a
remove punctuation normalization
dan-ince-aai 4e1ef17
ruff fix
dan-ince-aai 3b29150
ruff format
dan-ince-aai ca71588
add confidence values
dan-ince-aai 1c3af49
ruff format
dan-ince-aai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to move the text normalization to the STT plugin, you can compare the final transcript with the previous preflight version before sending it.