blingfire: add version constraints for pybind #3913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pybind recently updated to v3.0.0 which includes breaking changes and are incompatible with the existing implementation within blingfire. pybind11 is now fixed to >=2.13.6,<3.0 which ensures v2 is used
Member
|
Should we just recompile blingfire using the new ABIs? |
Contributor
Author
|
I don't know how your processes work so I don't have a strong opinion. I wanted to contribute to this repo, and in order to run the examples from a local install I had to compile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pybindrecently updated to v3.0.0 which includes breaking changes that are incompatible with the existing implementation of blingfire. This PR fixespybind11to>=2.13.6,<3.0which ensures v2 is used.