Fix issues identified by cppcheck#905
Merged
Merged
Conversation
Steven-Roberts
requested review from
balos1,
cswoodward,
drreynolds and
gardner48
as code owners
drreynolds
reviewed
Apr 8, 2026
Collaborator
drreynolds
left a comment
drreynolds
left a comment
There was a problem hiding this comment.
Aside from my one question below, this LGTM
balos1
previously approved these changes
Apr 8, 2026
gardner48
requested changes
Apr 12, 2026
Member
|
Also note in the change log / recent changes that potential memory leaks were fixed if a memory allocation fails. |
gardner48
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cppcheck flagged a few memory leaks in the unlikely case of a malloc failing in a constructor, and codex did a decent job at fixing them. These fixes aren't so important, but they make the cppcheck report shorter so it will be easier to identify more important issues in the future.