Add optional prefix for annotations #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llogiq
approved these changes
Oct 3, 2018
tests/opt_name.rs
Outdated
|
|
||
| pub struct Lower { | ||
|
|
||
| } |
There was a problem hiding this comment.
Is there a reason not to write this as pub struct Lower;?
src/lib.rs
Outdated
| a: Annotatable) -> Annotatable { | ||
| let opt_ident = match mi.node { | ||
| MetaItemKind::Word => None, | ||
| MetaItemKind::List(ref v) => { |
There was a problem hiding this comment.
Could this be simplified to match against MetaItemKind::List(ref v) if v.len() == 1 => { .. } and _ => None?
|
Thanks, I didn't know about those tricks back when I wrote this :) I also fixed the merge conflict that arose from removing quote_block. Should be all set now. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few people interested in issue #16. I just stumbled upon this crate -- I love the idea behind it, but I also need that feature to use it in my own work since I have a few different structs with methods of the same name.
I think having automatic full path names would be even nicer than this solution, but I'm not that well versed with writing language extensions just yet. In the meantime, this works well enough for my (and hopefully others') needs.