Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive has_self #11

Merged
merged 4 commits into from
Aug 15, 2021
Merged

Revive has_self #11

merged 4 commits into from
Aug 15, 2021

Conversation

Artoria2e5
Copy link
Contributor

@Artoria2e5 Artoria2e5 commented Aug 9, 2021

The commits achieve the following:

  • Revive the method call support from 298b0ff. The new func(self, ...) approach introduced in that commit does not seem to work and is not tested.
  • Revive the test case removed by the aforementioned commit. (Should fix Should work on methods #1 and Add example code #6, maybe also Option for syn/quote #10's question.)
  • Run rustfmt in hope that future diffs will be reduced.
  • Clarify that building of wasm is not necessary in README.

Copy link
Owner

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! If you want to add a drive-by typo fix, even greater, otherwise let me know & I'll merge & publish.

README.md Outdated
in code.


## Notes on watt

This new updated version usesi D. Tolnay's [watt] runtime to speed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I made a typo at "uses". Not related to this PR, but appreciated if you're up for a drive-by fix.

@llogiq
Copy link
Owner

llogiq commented Aug 15, 2021

Thank you so much! ❤️

@llogiq llogiq merged commit d9c1590 into llogiq:master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should work on methods
2 participants