Skip to content

Commit 2406e0d

Browse files
efriedma-quicllvmbot
authored andcommitted
Revert "[MC] Explicitly mark MCSymbol for MO_ExternalSymbol" (#133291)
Reverts #108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes #132055. (cherry picked from commit cd6e959)
1 parent 3d5f5ef commit 2406e0d

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

llvm/lib/Target/X86/X86MCInstLower.cpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -348,12 +348,8 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI,
348348
return MCOperand::createImm(MO.getImm());
349349
case MachineOperand::MO_MachineBasicBlock:
350350
case MachineOperand::MO_GlobalAddress:
351+
case MachineOperand::MO_ExternalSymbol:
351352
return LowerSymbolOperand(MO, GetSymbolFromOperand(MO));
352-
case MachineOperand::MO_ExternalSymbol: {
353-
MCSymbol *Sym = GetSymbolFromOperand(MO);
354-
Sym->setExternal(true);
355-
return LowerSymbolOperand(MO, Sym);
356-
}
357353
case MachineOperand::MO_MCSymbol:
358354
return LowerSymbolOperand(MO, MO.getMCSymbol());
359355
case MachineOperand::MO_JumpTableIndex:

0 commit comments

Comments
 (0)