[libc++] Mark string functions as [[nodiscard]] (#166524)

This applies `[[nodiscard]]` according to our coding guidelines to
`basic_string`.

Author: philnik777