Skip to content

Commit 3f7ca88

Browse files
authored
[lldb-dap] Add progress events to the packet list (#134157)
Before #134048, TestDAP_Progress relied on wait_for_event to block until the progressEnd came in. However, progress events were not added to the packet list, so this call would always time out. This PR makes it so that packets are added to the packet list, and you can block on them.
1 parent dedb632 commit 3f7ca88

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

-2
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,6 @@ def handle_recv_packet(self, packet):
255255
# and 'progressEnd' events. Keep these around in case test
256256
# cases want to verify them.
257257
self.progress_events.append(packet)
258-
# No need to add 'progress' event packets to our packets list.
259-
return keepGoing
260258

261259
elif packet_type == "response":
262260
if packet["command"] == "disconnect":

lldb/test/API/tools/lldb-dap/progress/TestDAP_Progress.py

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def verify_progress_events(
1919
expected_not_in_message=None,
2020
only_verify_first_update=False,
2121
):
22+
self.dap_server.wait_for_event("progressEnd")
2223
self.assertTrue(len(self.dap_server.progress_events) > 0)
2324
start_found = False
2425
update_found = False

0 commit comments

Comments
 (0)