Skip to content

[lldb] max_return_elements parameter not used in SBCommandInterpreter::HandleCompletionWithDescriptions #135553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eronnen opened this issue Apr 13, 2025 · 1 comment · Fixed by #135565
Closed

[lldb] max_return_elements parameter not used in SBCommandInterpreter::HandleCompletionWithDescriptions #135553

eronnen opened this issue Apr 13, 2025 · 1 comment · Fixed by #135565
Labels
lldb

Comments

@eronnen
Copy link
Contributor

eronnen commented Apr 13, 2025 •
edited
Loading

SBCommandInterpreter::HandleCompletionWithDescriptions potentially can return more than max_return_elements completions, can cause a major slowdown when trying to complete a breakpoint statement for a program with a lot of symbols
@eronnen eronnen mentioned this issue Apr 13, 2025
Merged
@llvmbot
Copy link
Member

llvmbot commented Apr 13, 2025

@llvm/issue-subscribers-lldb

Author: Ely Ronnen (eronnen)

`SBCommandInterpreter::HandleCompletionWithDescriptions` potentially can return more than `max_return_elements` completions, can cause a major slowdown when trying to complete a breakpoint statement for a program with a lot of symbols

JDevlieghere pushed a commit that referenced this issue Apr 23, 2025
@eronnen
[lldb] returning command completions up to a maximum (#135565)
6f5b98b 
- Adding `max_return_elements` field to `CompletionRequest`.
- adding maximum checks to `SymbolCompleter` and `SourceFileCompleter`.

Fixes #135553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lldb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lldb] returning command completions up to a maximum eronnen/llvm-project
3 participants
@EugeneZelenko @llvmbot @eronnen