Skip to content

Add tests for the dot4add functions #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add tests for the dot4add functions #192

wants to merge 3 commits into from

Conversation

bogner
Copy link
Collaborator

@bogner bogner commented May 16, 2025

We test dot4add_i8packed and dot4add_u8packed on the same inputs, showing the difference in signed vs unsigned results.

Fixes #123 and #149.

@bogner
Add tests for the dot4add functions
463be11 
We test `dot4add_i8packed` and `dot4add_u8packed` on the same inputs, showing
the difference in signed vs unsigned results.

Fixes llvm#123 and llvm#149.
spall
spall approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inbelic
inbelic approved these changes May 16, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spall spall spall approved these changes

@farzonl farzonl farzonl approved these changes

@inbelic inbelic inbelic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for dot4add_i8packed
4 participants
@bogner @spall @farzonl @inbelic