[ScalarizeShapes] Fold select.int through cat in shape computations#4513
Open
[ScalarizeShapes] Fold select.int through cat in shape computations#4513
Conversation
Extend getListFromTensor to recurse into aten.cat operands and add a select.int folding pattern. This resolves shape elements from concat-based shape tensors used by onnx.Reshape lowering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zjgarvey
reviewed
May 7, 2026
Collaborator
zjgarvey
left a comment
zjgarvey
left a comment
There was a problem hiding this comment.
Sorry for the extremely late review. This somehow got dropped from my queue after I went to look back at the prim op. I just have the one concern about the prim op being expected to return rank 0 sometimes, but otherwise this looks good to me.
|
|
||
| auto resultTy = cast<ValueTensorType>(op.getType()); | ||
| rewriter.replaceOp( | ||
| op, PrimNumToTensorScalarOp::create(b, resultTy, materialized.front())); |
Collaborator
There was a problem hiding this comment.
IIRC, the PrimNumToTensorScalarOp is expected to have a rank zero result in some places (e.g., some folding patterns). I think the abstract interp function is just return []. If we know the output is always shaped like [1] it might be better to use a full op just in case this causes issues anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend getListFromTensor to recurse into aten.cat operands and add a select.int folding pattern. This resolves shape elements from concat-based shape tensors used by onnx.Reshape lowering.