Skip to content

DecomposeAtenAminAmaxOp negative axis fix #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voonter wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −2
Open

DecomposeAtenAminAmaxOp negative axis fix #4556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2825,12 +2825,13 @@ class DecomposeAtenAminAmaxOp : public OpRewritePattern<OpTy> {
dims = llvm::to_vector(llvm::seq<int64_t>(0, inputTy.getSizes().size()));
}

int64_t inputRank = inputTy.getSizes().size();
llvm::for_each(dims, [&](int64_t &d) { d = toPositiveDim(d, inputRank); });

// For every dimension included in `dim` of the op, iterated over in
// reverse order, we create a call to aten.max.dim.
std::sort(dims.rbegin(), dims.rend());
for (int64_t dimInt : dims) {
int64_t inputRank = inputTy.getSizes().size();
dimInt = toPositiveDim(dimInt, inputRank);
if (!isValidDim(dimInt, inputRank))
return rewriter.notifyMatchFailure(op, "dim is statically invalid");
Value dim = Torch::ConstantIntOp::create(
Expand Down
21 changes: 21 additions & 0 deletions projects/pt1/python/torch_mlir_e2e_test/test_suite/reduction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,6 +1381,27 @@ def ReduceAmaxOutOfOrderDim_basic(module, tu: TestUtils):

# ==============================================================================

class ReduceAmaxOutOfOrderWithNegDim(torch.nn.Module):
def __init__(self):
super().__init__()

@export
@annotate_args(
[
None,
([-1, -1, -1, -1], torch.float32, True),
]
)
def forward(self, a):
return torch.ops.aten.amax(a, (2, 1, -1))


@register_test_case(module_factory=lambda: ReduceAmaxOutOfOrderWithNegDim())
def ReduceAmaxOutOfOrderWithNegDim_basic(module, tu: TestUtils):
module.forward(tu.rand(3, 4, 5, 6, high=100))


# ==============================================================================

class ReduceAmaxKeepDim(torch.nn.Module):
def __init__(self):
Expand Down