[TorchToTosa] Support flattened index_put updates in TOSA lowering#4561
Open
[TorchToTosa] Support flattened index_put updates in TOSA lowering#4561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TOSA lowering for index_put/scatter updates when the update tensor is already flattened.
Previously, fillK was computed from only the first ND dimensions of fillValues, which assumes updates still follow the indexed tensor shape. Flattened updates break that assumption and can produce invalid reshape/scatter shapes.
The fix derives fillK from the total number of update elements with a divisibility check. This supports both shaped and flattened updates while preserving the existing {N, fillK, C} scatter form. A regression test was added for flattened torch.aten.index_put.hacked_twin updates.