Fix: rejected valid callback responses#100
Merged
Merged
Conversation
dni
reviewed
Mar 9, 2026
dni
reviewed
Mar 9, 2026
dni
reviewed
Mar 9, 2026
Member
|
hey, i am fine with the change if we can word the comments as of my suggestions. |
Member
|
and please run |
Co-authored-by: dni ⚡ <office@dnilabs.com>
Contributor
Author
|
Accepted changes and ran |
dni
changed the title
dni
approved these changes
Mar 25, 2026
dni
left a comment
dni
left a comment
Member
There was a problem hiding this comment.
approved, will port the commit to v2/main and keep it for v1 branch for backwards compatibility
dni
added a commit
that referenced
this pull request
Mar 25, 2026
* fix: Fix rejected valid callback responses * Apply suggestions from code review Co-authored-by: dni ⚡ <office@dnilabs.com> * fix: remove unused imports from lud06 test * fixup! --------- Co-authored-by: dni ⚡ <office@dnilabs.com>
dni
added a commit
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added test.
Fixes #99