Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify TieredSpationJoin createReprojectMap return result Not comprehensive #1553

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

hsg77
Copy link

@hsg77 hsg77 commented May 6, 2019

modify TieredSpationJoin createReprojectMap return result Not comprehensive

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 45.638% when pulling 0b1bd3c on hsg77:master into 4f39304 on locationtech:master.

@rfecher
Copy link
Contributor

rfecher commented May 6, 2019

@JWileczek do you mind reviewing this one?

@rfecher
Copy link
Contributor

rfecher commented May 6, 2019

@hsg77 can you please sign the Eclipse Contributor Agreement: https://www.eclipse.org/legal/ECA.php

@hsg77
Copy link
Author

hsg77 commented May 7, 2019

The actual result is 30 31

However,.compute result is:
testLastIndex=2
firstGreater=-1
result=31

public static void testInsertPointCopy()
    {
        Byte[] testSide=new Byte[]{30,31};
        int testLastIndex = testSide.length;
        Byte tierLeft=15;
        int firstGreater=Arrays.binarySearch(testSide,tierLeft);
        System.out.println("testLastIndex="+testLastIndex);
        System.out.println("firstGreater="+firstGreater);
        int insertionPoint = Math.abs(firstGreater);
        if (insertionPoint >= testLastIndex) {
            // Not present in array, and none greater than this value
            System.out.println("InsertPoint>=lastIndex");
        }
        HashSet<Byte> higherTiers = Sets.newHashSet(Arrays.copyOfRange(
                testSide,
                insertionPoint,
                testLastIndex));
        System.out.print("result=");
        for(Byte t :higherTiers)
        {
            System.out.print(t+" ");
        }
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants