handle panics in queue worker #1274
Merged
+191
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users sometimes write code that panics. Right now the entire worker stops handling jobs when this happens. It makes sense to treat this as a regular error.
|
yes i think its a good approach, please continue |
also cargo fmt
jtwaleson
force-pushed
the
panic-resilient-workers
branch
2 times, most recently
from
083b1b7 to
bb79977
Compare
jtwaleson
force-pushed
the
panic-resilient-workers
branch
from
bb79977 to
14b3ab7
Compare
|
Ok, this should work! I did not add a the for sidekiq, as retrieving the job status does not seem to be supported. I would not know how to elegantly test this. The Async and Sync workers are left untouched, as I assume these are mostly used in development environments and there failing fast seems preferable. |
kaplanelad
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users sometimes write code that panics in background job handlers. Right now the entire worker stops handling jobs when this happens. IMHO it makes sense to treat this as a regular error because that makes it easier to use Loco.
Not sure if the maintainers are open to this approach because panics should maybe be handled in the job handler implementations.
If you would like to proceed with this approach, I'll add tests and apply the same to the other worker implementations. If not, I could add some documentation on how to make job handlers panic resistant.