Add SQLite parser for android burners app (burners.sqlite) file #4928
Conversation
|
Thanks for the PR, I'm a bit preoccupied at the moment will try to take a look as soon as time permits |
We're still working on the project, it's not finished yet. So I'm closing this pull request. Thank you. |
thanks for that context, note that you can change the PR to draft status as well |
|
@brokamal a couple of questions
|
joachimmetz
added
the
pending reporter input
| message: | ||
| - 'Phone Number: {phone_number_id}' | ||
| - 'Voice Mail: {voicemail_url}' | ||
| - 'User Id: {user_id}' |
There was a problem hiding this comment.
style guide nit: use identifier instead of id
| features (str): Features enabled for the burner. | ||
| total_minutes (int): Total minutes available for calls on the burner. | ||
| expiration_date (datetime): Expiration date of the burner. | ||
| date_created (datetime): Date the burner was created. |
There was a problem hiding this comment.
for consistency with the rest of the codebase please use creation_time (also applicable to the other date and time values)
| from plaso.containers import events | ||
| from plaso.parsers import sqlite | ||
| from plaso.parsers.sqlite_plugins import interface | ||
|
|
There was a problem hiding this comment.
style guide nit: use 2 empty lines
| self.date_created = None | ||
| self.last_updated_date = None | ||
| self.renewal_date = None | ||
|
|
There was a problem hiding this comment.
style guide nit: use 2 empty lines
| 'renewal_date') | ||
|
|
||
| parser_mediator.ProduceEventData(event_data) | ||
|
|
There was a problem hiding this comment.
style guide nit: use 2 empty lines
plugin initialization
|
rebased PR |
|
@brokamal can you PTAL at failing CI tests and linter warnings |
One line description of pull request
Add SQLite parser for android burners app (burners.sqlite) file
Description:
I add/edit several files:
(plaso/data/timeliner.yaml)
Related issue (if applicable): fixes #
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: