Skip to content

feat: add nix files needed for cpp code auto generation#9

Draft
Khushboo-dev-cpp wants to merge 1 commit intomasterfrom
feat/addNixFiles
Draft

feat: add nix files needed for cpp code auto generation#9
Khushboo-dev-cpp wants to merge 1 commit intomasterfrom
feat/addNixFiles

Conversation

@Khushboo-dev-cpp
Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp commented Feb 12, 2026

adding cpp generator for this module
and also aligning the nix files as done with standard modules
rename liblogos-blockchain-module to liblogos_blockchain_module
so that the cpp autogenerated files are with underscore with hyphen because C++ identifiers cannot contain hyphens

@Khushboo-dev-cpp Khushboo-dev-cpp marked this pull request as draft February 12, 2026 10:43
@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/addNixFiles branch 4 times, most recently from 81a8bb6 to 5783082 Compare February 12, 2026 22:17
@Khushboo-dev-cpp Khushboo-dev-cpp marked this pull request as ready for review February 13, 2026 08:19
Copy link
Contributor

@strinnityk strinnityk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions regarding the whole splitting thing but let's address them in order:

  • Why split the include and lib packaging?
  • Why are we overriding flake's cmake integration and specifying the commands manually?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we calling this default if this is just providing common definitions? We are even assigning it to a variable called common below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could call it common.nix too? I kind of kept the name consistent with other modules.

@Khushboo-dev-cpp
Copy link
Contributor Author

Khushboo-dev-cpp commented Feb 16, 2026

I have a few questions regarding the whole splitting thing but let's address them in order:

  • Why split the include and lib packaging?

The reason this is split is because the lib is to call Cmake to build the lib and include for calling the cpp-generator and generating headers. The cpp generator helps call cross module calls and hence Ive added the support to it.

  • Why are we overriding flake's cmake integration and specifying the commands manually?

hmm I think you are right, I am going to dive in and look at the CmakeLists.txt and again and check if we can remove the redundant parts.

@Khushboo-dev-cpp Khushboo-dev-cpp marked this pull request as draft February 18, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants