feat: add nix files needed for cpp code auto generation#9
feat: add nix files needed for cpp code auto generation#9Khushboo-dev-cpp wants to merge 1 commit intomasterfrom
Conversation
81a8bb6 to
5783082
Compare
strinnityk
left a comment
There was a problem hiding this comment.
I have a few questions regarding the whole splitting thing but let's address them in order:
- Why split the
includeandlibpackaging? - Why are we overriding flake's
cmakeintegration and specifying the commands manually?
There was a problem hiding this comment.
Why are we calling this default if this is just providing common definitions? We are even assigning it to a variable called common below.
There was a problem hiding this comment.
I guess we could call it common.nix too? I kind of kept the name consistent with other modules.
The reason this is split is because the lib is to call Cmake to build the lib and include for calling the cpp-generator and generating headers. The cpp generator helps call cross module calls and hence Ive added the support to it.
hmm I think you are right, I am going to dive in and look at the CmakeLists.txt and again and check if we can remove the redundant parts. |
5783082 to
2bf8678
Compare
2bf8678 to
71140b0
Compare
adding cpp generator for this module
and also aligning the nix files as done with standard modules
rename liblogos-blockchain-module to
liblogos_blockchain_moduleso that the cpp autogenerated files are with underscore with hyphen because C++ identifiers cannot contain hyphens