Skip to content

Key protocol compatibility with BIP-032/Keycard#356

Open
jonesmarvin8 wants to merge 9 commits intomainfrom
marvin/bip-32-comp
Open

Key protocol compatibility with BIP-032/Keycard#356
jonesmarvin8 wants to merge 9 commits intomainfrom
marvin/bip-32-comp

Conversation

@jonesmarvin8
Copy link
Collaborator

🎯 Purpose

Fixes deviations from BIP-032 for compatibility with Keycard; addresses Issue 355.

⚙️ Approach

  • Uses big endian for indices (public and private account keys for consistency)
  • Non-harden keys (public account) uses full public key (33-bytes) for generation of children keys.
  • Updated key tests

🧪 How to Test

RISC0_DEV_MODE=1 cargo test in key_protocol.

🔗 Dependencies

N/A

🔜 Future Work

N/A

📋 PR Completion Checklist

  • Complete PR description
  • Implement the core functionality
  • Add/update tests
  • Add/update documentation and inline comments

@jonesmarvin8 jonesmarvin8 marked this pull request as ready for review February 26, 2026 23:22
Copy link
Collaborator

@Pravdyvy Pravdyvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me, it changes accounts in wallet config, therefore need to change accounts in sequencer and indexer configs correspondingly to be in sync.

Copy link
Collaborator

@Pravdyvy Pravdyvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think latest main fixes this integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants