Key protocol compatibility with BIP-032/Keycard#356
Open
jonesmarvin8 wants to merge 9 commits intomainfrom
Open
Key protocol compatibility with BIP-032/Keycard#356jonesmarvin8 wants to merge 9 commits intomainfrom
jonesmarvin8 wants to merge 9 commits intomainfrom
Conversation
Pravdyvy
requested changes
Feb 27, 2026
Collaborator
Pravdyvy
left a comment
There was a problem hiding this comment.
Looks fine for me, it changes accounts in wallet config, therefore need to change accounts in sequencer and indexer configs correspondingly to be in sync.
4 tasks
Pravdyvy
approved these changes
Mar 9, 2026
Collaborator
Pravdyvy
left a comment
There was a problem hiding this comment.
lgtm. I think latest main fixes this integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
Fixes deviations from BIP-032 for compatibility with Keycard; addresses Issue 355.
⚙️ Approach
🧪 How to Test
RISC0_DEV_MODE=1 cargo testinkey_protocol.🔗 Dependencies
N/A
🔜 Future Work
N/A
📋 PR Completion Checklist