refactor(console): refactor SIE settings form #7154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeng-li
requested review from
wangsijie,
charIeszhao,
xiaoyijun and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignInForm/SignInMethodEditBox/index.tsx | 📈 +465 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpForm.tsx | 📈 +6.59 KB |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpIdentifiersEditBox/SignUpIdentifierItem.module.scss | 📈 +612 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpIdentifiersEditBox/SignUpIdentifierItem.tsx | 📈 +1.61 KB |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpIdentifiersEditBox/index.module.scss | 📈 +56 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpIdentifiersEditBox/index.tsx | 📈 +4.45 KB |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/index.tsx | 📈 +699 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/components/IdentifiersAddButton/index.module.scss | 📈 +102 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/components/IdentifiersAddButton/index.tsx | 📈 +2.08 KB |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/index.tsx | 📈 +151 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/utils.ts | 📈 +230 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/constants.ts | 📈 +108 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/utils/parser.ts | 📈 +2.67 KB |
| packages/console/src/pages/SignInExperience/types.ts | 📈 +753 Bytes |
| packages/core/src/libraries/sign-in-experience/sign-in.test.ts | 📈 +670 Bytes |
| packages/core/src/libraries/sign-in-experience/sign-in.ts | 📈 +213 Bytes |
| packages/integration-tests/src/tests/console/sign-in-experience/sign-up-and-sign-in/happy-path.test.ts | 📈 +303 Bytes |
| packages/integration-tests/src/tests/console/sign-in-experience/sign-up-and-sign-in/sad-path.test.ts | 📈 +93 Bytes |
| packages/integration-tests/src/utils.ts | 📈 +163 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📈 +3 Bytes |
| packages/schemas/src/foundations/jsonb-types/sign-in-experience.ts | 📈 +50 Bytes |
wangsijie
approved these changes
Mar 19, 2025
xiaoyijun
approved these changes
Mar 20, 2025
packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/index.tsx
Show resolved
Hide resolved
simeng-li
force-pushed
the
simeng-log-10898-console-refactor-sign-up-and-sign-in-form
branch
from
697d3c4 to
6df802e
Compare
simeng-li
force-pushed
the
simeng-log-10932-experience-update-the-experience-sign-up-form-render-logic
branch
2 times, most recently
from
e26d414 to
89a21e2
Compare
simeng-li
force-pushed
the
simeng-log-10898-console-refactor-sign-up-and-sign-in-form
branch
from
6df802e to
ba151b0
Compare
simeng-li
force-pushed
the
simeng-log-10932-experience-update-the-experience-sign-up-form-render-logic
branch
from
89a21e2 to
8a38d05
Compare
simeng-li
force-pushed
the
simeng-log-10898-console-refactor-sign-up-and-sign-in-form
branch
from
ba151b0 to
acdab07
Compare
Base automatically changed from
simeng-log-10932-experience-update-the-experience-sign-up-form-render-logic
to
master
March 24, 2025 06:01
remove mandatory sign-in password verification rule
refactor SIE settings form
simeng-li
force-pushed
the
simeng-log-10898-console-refactor-sign-up-and-sign-in-form
branch
from
acdab07 to
3d7aab7
Compare
update SIE page to support multi sign-up identifiers
disable test cases for devFeature
disable some console tests for devFeature
fix emailOrPhone sign-in method sync
simeng-li
deleted the
simeng-log-10898-console-refactor-sign-up-and-sign-in-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the following updates:
Core
Removed the restriction rule in the sign-in experience settings:
Console
Refactor the console sign-in and sign-up settings page to align with the recent sign-in experience validation rule updates.
Password is no longer mandatory when using
usernameas a sign-up identifier.The password option in the sign-up settings is now editable. Note: When
usernameis selected as a sign-up identifier, the system will still auto-enable the password option by default. However, users can manually deselect it if they prefer.Sign-up identifiers are no longer required in sign-in methods.
All sign-in methods are now optional. Newly assigned sign-up identifiers will still be auto-appended to the sign-in methods list if they are not already included. However, users can manually remove them if they choose not to support them for sign-in.
Password is no longer mandatory for email and phone number sign-in methods, even when password verification is enabled for sign-up.
The password option is now editable for email and phone number sign-in methods, giving users more flexibility to configure their preferred sign-in experience.
Testing
test locally
Checklist
.changeset